netrom: Fix a memory leak in nr_heartbeat_expiry()
Published Jul 12, 2024
5.5
MEDIUMCVSS 3.1
EPSS 0.24%
Description
syzbot reported a memory leak in nr_create() [0].
Commit 409db27e3a2e ("netrom: Fix use-after-free of a listening socket.") added sock_hold() to the nr_heartbeat_expiry() function, where a) a socket has a SOCK_DESTROY flag or b) a listening socket has a SOCK_DEAD flag.
But in the case "a," when the SOCK_DESTROY flag is set, the file descriptor has already been closed and the nr_release() function has been called. So it makes no sense to hold the reference count because no one will call another nr_destroy_socket() and put it as in the case "b."
nr_connect nr_establish_data_link nr_start_heartbeat
nr_release switch (nr->state) case NR_STATE_3 nr->state = NR_STATE_2 sock_set_flag(sk, SOCK_DESTROY);
nr_rx_frame nr_process_rx_frame switch (nr->state) case NR_STATE_2 nr_state2_machine() nr_disconnect() nr_sk(sk)->state = NR_STATE_0 sock_set_flag(sk, SOCK_DEAD)
nr_heartbeat_expiry switch (nr->state) case NR_STATE_0 if (sock_flag(sk, SOCK_DESTROY) || (sk->sk_state == TCP_LISTEN && sock_flag(sk, SOCK_DEAD))) sock_hold() // ( !!! ) nr_destroy_socket()
To fix the memory leak, let's call sock_hold() only for a listening socket.
Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with Syzkaller.
[0]: https://syzkaller.appspot.com/bug?extid=d327a1f3b12e1e206c16
Affected products
-
- Version 4.14.305StatusaffectedConstraints<4.15
- Version 4.19.272StatusaffectedConstraints<4.19.317
- Version 5.10.166StatusaffectedConstraints<5.10.221
- Version 5.15.91StatusaffectedConstraints<5.15.162
- Version 5.4.231StatusaffectedConstraints<5.4.279
- Version 6.1.9StatusaffectedConstraints<6.1.96
- Version
-
- Version StatusaffectedConstraints
- Version StatusaffectedConstraints
- Version StatusaffectedConstraints
- Version StatusaffectedConstraints
- Version StatusaffectedConstraints
- Version StatusaffectedConstraints
- Version StatusaffectedConstraints
- Version StatusaffectedConstraints-
- Version StatusaffectedConstraints
- Version
-
- Version 6.2StatusaffectedConstraints-
- Version 0StatusunaffectedConstraints<6.2
- Version 4.19.317StatusunaffectedConstraints<=4.19.*
- Version 5.10.221StatusunaffectedConstraints<=5.10.*
- Version 5.15.162StatusunaffectedConstraints<=5.15.*
- Version 5.4.279StatusunaffectedConstraints<=5.4.*
- Version 6.1.96StatusunaffectedConstraints<=6.1.*
- Version 6.10StatusunaffectedConstraints<=*
- Version 6.6.36StatusunaffectedConstraints<=6.6.*
- Version 6.9.7StatusunaffectedConstraints<=6.9.*
- Version
Default status is the baseline for the product, each version can override it (e.g. patched versions marked unaffected).
| Vendor | Product | Default status | Versions | |||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Linux | Linux | unaffected |
| |||||||||||||||||||||||||||||||||
| Linux | Linux | unaffected |
| |||||||||||||||||||||||||||||||||
| Linux | Linux | affected |
|
- ≥ 4.19.272 · < 4.19.317
- ≥ 5.4.231 · < 5.4.279
- ≥ 5.10.166 · < 5.10.221
- ≥ 5.15.91 · < 5.15.162
- ≥ 6.1.9 · < 6.1.96
- ≥ 6.2 · < 6.6.36
- ≥ 6.7 · < 6.9.7
- 6.10
- 6.10
- 6.10
- 6.10
No data.
Red Hat Enterprise Linux 6
kernel
Not affected
Red Hat Enterprise Linux 7
kernel
Not affected
Red Hat Enterprise Linux 7
kernel-rt
Not affected
Red Hat Enterprise Linux 8
kernel
Not affected
Red Hat Enterprise Linux 8
kernel-rt
Not affected
Red Hat Enterprise Linux 9
kernel
Not affected
Red Hat Enterprise Linux 9
kernel-rt
Not affected
| Product | Package | State | Advisory |
|---|---|---|---|
| Red Hat Enterprise Linux 6 | kernel | Not affected | n/a |
| Red Hat Enterprise Linux 7 | kernel | Not affected | n/a |
| Red Hat Enterprise Linux 7 | kernel-rt | Not affected | n/a |
| Red Hat Enterprise Linux 8 | kernel | Not affected | n/a |
| Red Hat Enterprise Linux 8 | kernel-rt | Not affected | n/a |
| Red Hat Enterprise Linux 9 | kernel | Not affected | n/a |
| Red Hat Enterprise Linux 9 | kernel-rt | Not affected | n/a |
No package ranges for this CVE.
Remediation
No remediation recorded yet.
References (17)
- https://access.redhat.com/security/cve/CVE-2024-41006 Vendor Advisory
- https://bugzilla.redhat.com/show_bug.cgi?id=2297590 Issue Tracking
- https://cert-portal.siemens.com/productcert/html/ssa-265688.html
- https://cert-portal.siemens.com/productcert/html/ssa-355557.html
- https://cert-portal.siemens.com/productcert/html/ssa-613116.html
- https://git.kernel.org/stable/c/0b9130247f3b6a1122478471ff0e014ea96bb735 Mailing ListPatch
- https://git.kernel.org/stable/c/280cf1173726a7059b628c610c71050d5c0b6937 Mailing ListPatch
- https://git.kernel.org/stable/c/5391f9db2cab5ef1cb411be1ab7dbec728078fba Mailing ListPatch
- https://git.kernel.org/stable/c/a02fd5d775cf9787ee7698c797e20f2fa13d2e2b Mailing ListPatch
- https://git.kernel.org/stable/c/b6ebe4fed73eedeb73f4540f8edc4871945474c8 Mailing ListPatch
- https://git.kernel.org/stable/c/d377f5a28332954b19e373d36823e59830ab1712 Mailing ListPatch
- https://git.kernel.org/stable/c/d616876256b38ecf9a1a1c7d674192c5346bc69c Mailing ListPatch
- https://git.kernel.org/stable/c/e07a9c2a850cdebf625e7a1b8171bd23a8554313 Mailing ListPatch
- https://lists.debian.org/debian-lts-announce/2025/01/msg00001.html
- https://lore.kernel.org/linux-cve-announce/2024071244-CVE-2024-41006-d24b@gregkh/T
- https://nvd.nist.gov/vuln/detail/CVE-2024-41006
- https://www.cve.org/CVERecord?id=CVE-2024-41006
Change history (0)
No recorded changes yet.